Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake: Remove unused #2711

Closed
wants to merge 2 commits into from

Conversation

Projects
None yet
3 participants
@ruslo
Copy link
Contributor

commented Jul 5, 2018

No description provided.

@bagder bagder added the cmake label Jul 5, 2018

@@ -309,13 +309,13 @@ if(WIN32 OR CMAKE_USE_DARWINSSL OR CMAKE_USE_WINSSL OR CMAKE_USE_MBEDTLS)
endif()
option(CMAKE_USE_OPENSSL "Use OpenSSL code. Experimental" ${openssl_default})

collect_true(enabled_ssl_options enabled_ssl_options_count
count_true(num

This comment has been minimized.

Copy link
@jzakrzewski

jzakrzewski Jul 5, 2018

Contributor

Given the scope of the variable, calling it "num" is probably not such a good idea. I'd rather leave the old name here.

This comment has been minimized.

Copy link
@ruslo

ruslo Jul 5, 2018

Author Contributor

Fixed

CMake: Remove unused 'output_var' from 'collect_true'
Variable 'output_var' is not used and can be removed.
Function 'collect_true' renamed to 'count_true'.

@ruslo ruslo force-pushed the ruslo:pr.unused branch from 5e50b73 to f322572 Jul 5, 2018

@bagder

This comment has been minimized.

Copy link
Member

commented Jul 6, 2018

Thanks!

@bagder bagder closed this in fac400d Jul 6, 2018

@ruslo ruslo deleted the ruslo:pr.unused branch Jul 6, 2018

xquery added a commit to xquery/curl that referenced this pull request Jul 6, 2018

@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.