Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake: Remove redundant code #2715

Closed
wants to merge 1 commit into from
Closed

CMake: Remove redundant code #2715

wants to merge 1 commit into from

Conversation

ruslo
Copy link
Contributor

@ruslo ruslo commented Jul 6, 2018

No description provided.

@bagder bagder added the cmake label Jul 6, 2018
@bagder bagder requested a review from jzakrzewski Jul 9, 2018
Copy link
Contributor

@jzakrzewski jzakrzewski left a comment

I cannot test it at the moment but since the CMake builds completed there cannot be subtle typos.
The PR basically cleans up old (long obsolete) block syntax, which is good for readability.
I'd only change the commit message to say exactly that instead of "Remove redundant code".

@ruslo
Copy link
Contributor Author

ruslo commented Jul 9, 2018

I'd only change the commit message to say exactly that instead of "Remove redundant code".

Do you want me to update pull request or you can do it yourself by cherry-picking? If you want me to update the commit summary can you write exaclty what message you think is some appropriate here.

@bagder bagder closed this in e0a4bba Jul 9, 2018
@bagder
Copy link
Member

bagder commented Jul 9, 2018

Thanks. I merged and edited the commit message before I pushed.

@ruslo ruslo deleted the pr.redundant branch Jul 10, 2018
falconindy pushed a commit to falconindy/curl that referenced this pull request Sep 10, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Oct 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants