New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

darwinssl: add support for ALPN negotiation #2731

Merged
merged 1 commit into from Jul 14, 2018

Conversation

Projects
None yet
3 participants
@rcombs
Contributor

rcombs commented Jul 11, 2018

Rewrite of #500 using the public APIs introduced in macOS 10.13 and iOS 11.

@bagder bagder requested a review from nickzman Jul 11, 2018

@bagder bagder added the SSL/TLS label Jul 11, 2018

@nickzman

The code looks okay, compiles okay, and does make HTTP/2 work as expected. It is important, though, to exclude versions of High Sierra prior to 10.13.4. Thanks for working on this.

Show outdated Hide outdated lib/vtls/darwinssl.c
Show outdated Hide outdated docs/HTTP2.md
@rcombs

This comment has been minimized.

Show comment
Hide comment
@rcombs

rcombs Jul 14, 2018

Contributor

Not sure if you caught it; I've re-pushed this with your comments addressed.

Contributor

rcombs commented Jul 14, 2018

Not sure if you caught it; I've re-pushed this with your comments addressed.

@nickzman

Thanks for working on this!

@nickzman nickzman merged commit 092f681 into curl:master Jul 14, 2018

5 checks passed

LGTM analysis: C/C++ No alert changes
Details
LGTM analysis: Python No alert changes
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.04%) to 75.565%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment