New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issues found when multiplexing #2733

Closed
wants to merge 4 commits into
base: master
from

Conversation

Projects
None yet
1 participant
@bagder
Member

bagder commented Jul 11, 2018

Found and fixed while working on #2674.

Replaces #2722

bagder added some commits Jul 3, 2018

conn: remove the boolean 'inuse' field
... as the usage needs to be counted.
Curl_getoff_all_pipelines: improved for multiplexed
On multiplexed connections, transfers can be removed from anywhere not
just at the head as for pipelines.
multi: always do the COMPLETED procedure
libteste/libntlmconnect.c wronly depended on wrong behavior (that it
would get a zero timeout) that is no longer present with this fix. Now
libcurl will always return a -1 timeout when all handles are completed.

@bagder bagder added the HTTP/2 label Jul 11, 2018

@bagder bagder closed this in acefdd0 Jul 11, 2018

@bagder bagder deleted the bagder/issues-found-when-plexing branch Jul 11, 2018

falconindy added a commit to falconindy/curl that referenced this pull request Sep 10, 2018

multi: always do the COMPLETED procedure/state
It was previously erroneously skipped in some situations.

libtest/libntlmconnect.c wrongly depended on wrong behavior (that it
would get a zero timeout) when no handles are "running" in a multi
handle. That behavior is no longer present with this fix. Now libcurl
will always return a -1 timeout when all handles are completed.

Closes curl#2733

@lock lock bot locked as resolved and limited conversation to collaborators Oct 9, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.