New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http2: several cleanups #2751

Closed
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
1 participant
@bagder
Member

bagder commented Jul 16, 2018

  • separate easy handle from connections better
  • added asserts on a number of places
  • added sanity check of pipelines for debug builds

@bagder bagder added the HTTP/2 label Jul 16, 2018

http2: several cleanups
- separate easy handle from connections better
- added asserts on a number of places
- added sanity check of pipelines for debug builds

@bagder bagder force-pushed the bagder/http2-data-conn-separations branch from cb984a6 to a248e62 Jul 17, 2018

bagder added some commits Jul 19, 2018

smb_getsock: wait for write socket too always
... the protocol is doing read/write a lot, so it needs to write often
even when downloading. A more proper fix could check for eactly when it
wants to write and only ask for it then.
@bagder

This comment has been minimized.

Member

bagder commented Jul 20, 2018

The smb fix is also split off and will be merged separately in #2768 - but without that fix, the event-based tests will hang when this branch is tested.

@bagder bagder closed this in 7b9bc96 Jul 20, 2018

@bagder bagder deleted the bagder/http2-data-conn-separations branch Jul 20, 2018

xquery added a commit to xquery/curl that referenced this pull request Aug 9, 2018

http2: several cleanups
- separate easy handle from connections better
- added asserts on a number of places
- added sanity check of pipelines for debug builds

Closes curl#2751

falconindy added a commit to falconindy/curl that referenced this pull request Sep 10, 2018

http2: several cleanups
- separate easy handle from connections better
- added asserts on a number of places
- added sanity check of pipelines for debug builds

Closes curl#2751

@lock lock bot locked as resolved and limited conversation to collaborators Oct 18, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.