CMake: Respect BUILD_SHARED_LIBS

[ruslo]

Use standard CMake variable BUILD_SHARED_LIBS instead of introducing
custom option CURL_STATICLIB.

[jzakrzewski]

I am not sure about this (even though I actually prefer using standard ways of doing things) because it inverts the default we had. I feel that

• most of people want dynamic libs
• building and using static libs is more involved

But the CMake documentation says: "This variable is often added to projects as an OPTION so that each user of a project can decide if they want to build the project using shared or static libraries."
If it would be an OPTION, we could probably have it defaulted to ON.

[ruslo]

because it inverts the default we had

option added, by default shared library will be build.

[snikulov]

@ruslo Appveyour should also be updated not to use CURL_STATICLIB

[ruslo]

Appveyour should also be updated not to use CURL_STATICLIB

Done

[bagder]

CURL_STATICLIB is not really "introduced" by this code. The define is used and known by the public curl/curl.h header. See

curl/include/curl/curl.h

Line 110 in 7bc1180

#ifdef CURL_STATICLIB

[ruslo]

CURL_STATICLIB is not really "introduced" by this code. The define is used and known by the public curl/curl.h header. See

@bagder C++ part is not affected by this change, CURL_SHATICLIB still defined by curl_config.h header, see configure_file step:

if(BUILD_SHARED_LIBS)
  set(CURL_STATICLIB NO)
else()
  set(CURL_STATICLIB YES)
endif()

# Use:
# * CURL_STATICLIB
 configure_file(curl_config.h.cmake
   ${CMAKE_CURRENT_BINARY_DIR}/curl_config.h)

[snikulov]

LGTM 👍

[bagder]

Thanks!