New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smb_getsock: always wait for write socket too #2768

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
1 participant
@bagder
Member

bagder commented Jul 20, 2018

... the protocol is doing read/write a lot, so it needs to write often
even when downloading. A more proper fix could check for eactly when it
wants to write and only ask for it then.

smb_getsock: always wait for write socket too
... the protocol is doing read/write a lot, so it needs to write often
even when downloading. A more proper fix could check for eactly when it
wants to write and only ask for it then.

@bagder bagder referenced this pull request Jul 20, 2018

Closed

http2: several cleanups #2751

@bagder bagder closed this in 73af7bc Jul 20, 2018

@bagder bagder deleted the bagder/smb_getsock branch Jul 20, 2018

xquery added a commit to xquery/curl that referenced this pull request Aug 9, 2018

smb_getsock: always wait for write socket too
... the protocol is doing read/write a lot, so it needs to write often
even when downloading. A more proper fix could check for eactly when it
wants to write and only ask for it then.

Without this fix, an SMB download could easily get stuck when the event-driven
API was used.

Closes curl#2768

falconindy added a commit to falconindy/curl that referenced this pull request Sep 10, 2018

smb_getsock: always wait for write socket too
... the protocol is doing read/write a lot, so it needs to write often
even when downloading. A more proper fix could check for eactly when it
wants to write and only ask for it then.

Without this fix, an SMB download could easily get stuck when the event-driven
API was used.

Closes curl#2768

@lock lock bot locked as resolved and limited conversation to collaborators Oct 18, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.