Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
test1148: disable if decimal separator is not a point #2786
There are a bunch of tests that set the environment in this way and they all can't be fixed this way. And are you sure that , and . are the only two decimal separator characters possible in any locale? It seems a better way to solve this would be to detect environments where the environment can't be set like this and skip the test, or skip the test if the environment requested is different from the one actually currently set.
There are other decimal separators, but I couldn't find any others that are for Hindu-Arabic numerals. Good point, I have to test what happens with languages with other numeral systems. Removing
How would you implement skipping such tests? Using
I tried with locales
This happens when building for native Windows (e.g. using MSVC or MinGW), but not when building for MSYS, so there's probably no good solution without running any code.
Jul 26, 2018
added a commit
this pull request
Jul 26, 2018
That was fun! Something like this?
Unfortunately, Perl is not my native language and this is the first time I touched an automake file, so I'm not sure if I got this right. But it does work - the test is skipped in my German MSYS2 MinGW shell, where it previously failed, but not in my German MSYS2 MSYS shell, where it succeeds.
But, when I had
I still have to update potential other tests setting