Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windows: fix version checking #2792

Closed
wants to merge 1 commit into from
Closed

Conversation

djelinski
Copy link
Contributor

@djelinski djelinski commented Jul 25, 2018

In the current version, VERSION_GREATER_THAN_EQUAL 6.3 will return false when run on windows 10.0. This patch addresses that error.

because 10.0 >= 6.3
@MarcelRaad
Copy link
Member

@MarcelRaad MarcelRaad commented Jul 25, 2018

Thanks for the patch!
How did you manage to run into this !defined(_WIN32_WINNT) || !defined(_WIN32_WINNT_WIN2K) || (_WIN32_WINNT < _WIN32_WINNT_WIN2K) case? Are you building for an ancient Windows version?

@MarcelRaad
Copy link
Member

@MarcelRaad MarcelRaad commented Jul 25, 2018

Note: it's probably easier for you to create PRs from branches other than master. Otherwise, you will have to check out the master branch again to base an eventual next PR on after this one is merged.

@djelinski
Copy link
Contributor Author

@djelinski djelinski commented Jul 25, 2018

D'oh. I didn't check if that code is ever used. I just noticed it while reading code and it looked wrong.
Thanks for the hint about using different branches, will keep it in mind.

@bagder bagder added the Windows label Jul 25, 2018
@MarcelRaad MarcelRaad self-assigned this Jul 25, 2018
xquery pushed a commit to xquery/curl that referenced this issue Aug 9, 2018
In the current version, VERSION_GREATER_THAN_EQUAL 6.3 will return false
when run on windows 10.0. This patch addresses that error.

Closes curl#2792
falconindy pushed a commit to falconindy/curl that referenced this issue Sep 10, 2018
In the current version, VERSION_GREATER_THAN_EQUAL 6.3 will return false
when run on windows 10.0. This patch addresses that error.

Closes curl#2792
@lock lock bot locked as resolved and limited conversation to collaborators Oct 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants