Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Bugfix: Fix segfault when -H @headerfile is empty #2797
@jay: I felt it was a lot safer to change the error handling locally in that spot only since the file2memory function is used in a number of other places. The risk of introducing new bugs is much bigger if the behaviour of the file2memory function is changed, don't you agree?
@bagder: I find it a bit hard to understand how the tests are supposed to work. I used cmake to build curl but a "make test" does not seem to be the right way to trigger the tests. I get:
Reading the README in the tests directory I get the impression that autotools should be used instead of cmake. Is autotools used when building tests and cmake when building the lib and binaries? I'm a bit confused. Can you point me in the right direction, or should we skip writing a test for this as @jay suggests?