URL API

[bagder]

The URL API. Man pages with all the details and a fair amount of tests are included. I encourage all interested parties to try it out and report your experiences, both good and bad!

---

I'm saving these items until after the initial merge and done as separate PRs:

• make libcurl use this parser internally too to avoid different treatment
• add CURLOPT_CURLU to allow passing in a URL handle to work with
• CURLU_CANONICAL - if there's a desire.

[xquery]

looks good to me, there is some good inspiration over at https://github.com/uriparser/uriparser/blob/master/test/test.cpp
for other test variants.

[vszakats]

Minor nit: An unnecessary empty line slipped in here.

[bagder]

oops

[vszakats]

Is there any reason why const isn't used in this prototype, for URL?:

CURLUcode curl_url(char *URL, CURLURL **urlhandle, unsigned int flags)

This function makes a call to parseurl(), where a const could added as well, and where internally the buffer isn't written nor passed to functions that write into it. ...it's possible I missed something reading the code.

UPDATE: Forgot to say: Thanks for this API, it is very useful!

[bagder]

No reason at all really. It's just an old weakness of mine to skip out on the 'const's... I'll fix. Thanks!

[bagder]

More minor fixes, squashed and rebased.

[vszakats]

Thanks for the constifying, it's looking good! One minor: curl_url() prototype above needs to be synced with this change.

[bagder]

I think coveralls got some hiccups there when it claims a -3.4% less test coverage, as this patch provides quite a bit of testing already. I'm ignoring that for now, as I hope to add more tests anyway as I go along and fix the remaining parts.

[bagder]

I'm not entirely happy with how curl_url() works just now, as just now we have two ways we can set a URL to the handle. I'm switching from:

Current

  CURLURL *h;
  rc = curl_url("http://example.com", &h, 0); /* create handle *

I suspect that way of storing the handle pointer is going to cause users grief. A bit too unusual.

New

  CURLURL *h = curl_url(); /* create handle */
  curl_url_set(h, CURLUPART_URL, "http://example.com", 0);

It is more in style with how our other APIs work and makes sure there's one single way to set URL in the handle,

Syntax-check a URL

A downside with this approach is that there's no longer any "shortcut" for just syntax-checking a URL without creating a handle, but then again I'm not convinced that's a very important feature.

[bagder]

I've synced the wiki page to match how the current patch implements the API.