Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove (some) unused macros #2852

Closed
wants to merge 5 commits into from
Closed

Remove (some) unused macros #2852

wants to merge 5 commits into from

Conversation

rikardfalkeborn
Copy link
Contributor

I gave Clangs -Wunused-macros a go and it showed a couple of warnings. IMO the warning is far too noisy to turn on for normal builds (I don't think it is not worth conditionally defining certain macros depending on which platform/compiler/configuration is used, and it'd be silly to remove i.e. CURL_MASK_SCHAR from warnless.c even though it's not used since just about every other MASK exists and is used). The macros in this PR should be fine to remove. Perhaps I could have just squashed the commits, but one at the time makes it possible to be more verbose in the commit message. :)

@rikardfalkeborn
telnet: Remove unused macros TELOPTS and TELCMDS
fd5357d 
Their usage was removed in 3a14518.
@rikardfalkeborn
formdata: Remove unused macro HTTPPOST_CONTENTTYPE_DEFAULT
d3b1e5e 
Its usage was removed in
84ad1fd.
@rikardfalkeborn
http_proxy: Remove unused macro SELECT_TIMEOUT
d712e6e 
Usage was removed in 5113ad0.
@rikardfalkeborn
asyn-thread: Remove unused macro
f764ba8 
The macro seems to never have been used.
@rikardfalkeborn
test1540: Remove unused macro TEST_HANG_TIMEOUT
60cd518 
The macro has never been used, and it there is not really any place
where it would make sense to add timing checks.
@rikardfalkeborn rikardfalkeborn mentioned this pull request Aug 8, 2018
Closed
@bagder
Copy link
Member

bagder commented Aug 9, 2018

Thanks!

@bagder bagder closed this in 489ac01 Aug 9, 2018
bagder pushed a commit that referenced this pull request Aug 9, 2018
@rikardfalkeborn @bagder
formdata: Remove unused macro HTTPPOST_CONTENTTYPE_DEFAULT
d5304c3 
Its usage was removed in
84ad1fd.

Closes #2852
bagder pushed a commit that referenced this pull request Aug 9, 2018
@rikardfalkeborn @bagder
http_proxy: Remove unused macro SELECT_TIMEOUT
64c01db 
Usage was removed in 5113ad0.

Closes #2852
bagder pushed a commit that referenced this pull request Aug 9, 2018
@rikardfalkeborn @bagder
asyn-thread: Remove unused macro
1c14ba6 
The macro seems to never have been used.

Closes #2852
bagder pushed a commit that referenced this pull request Aug 9, 2018
@rikardfalkeborn @bagder
test1540: Remove unused macro TEST_HANG_TIMEOUT
8ea0bae 
The macro has never been used, and it there is not really any place
where it would make sense to add timing checks.

Closes #2852
@rikardfalkeborn rikardfalkeborn deleted the remove-unused-macros branch August 9, 2018 20:35
xquery pushed a commit to xquery/curl that referenced this pull request Sep 3, 2018
@rikardfalkeborn @xquery
telnet: Remove unused macros TELOPTS and TELCMDS
f1122a1 
Their usage was removed in 3a14518.

Closes curl#2852
xquery pushed a commit to xquery/curl that referenced this pull request Sep 3, 2018
@rikardfalkeborn @xquery
formdata: Remove unused macro HTTPPOST_CONTENTTYPE_DEFAULT
254242d 
Its usage was removed in
84ad1fd.

Closes curl#2852
xquery pushed a commit to xquery/curl that referenced this pull request Sep 3, 2018
@rikardfalkeborn @xquery
http_proxy: Remove unused macro SELECT_TIMEOUT
c14156f 
Usage was removed in 5113ad0.

Closes curl#2852
xquery pushed a commit to xquery/curl that referenced this pull request Sep 3, 2018
@rikardfalkeborn @xquery
asyn-thread: Remove unused macro
6869908 
The macro seems to never have been used.

Closes curl#2852
xquery pushed a commit to xquery/curl that referenced this pull request Sep 3, 2018
@rikardfalkeborn @xquery
test1540: Remove unused macro TEST_HANG_TIMEOUT
6810179 
The macro has never been used, and it there is not really any place
where it would make sense to add timing checks.

Closes curl#2852
falconindy pushed a commit to falconindy/curl that referenced this pull request Sep 10, 2018
@rikardfalkeborn @falconindy
telnet: Remove unused macros TELOPTS and TELCMDS
77472cf 
Their usage was removed in 3a14518.

Closes curl#2852
falconindy pushed a commit to falconindy/curl that referenced this pull request Sep 10, 2018
@rikardfalkeborn @falconindy
formdata: Remove unused macro HTTPPOST_CONTENTTYPE_DEFAULT
b05729a 
Its usage was removed in
84ad1fd.

Closes curl#2852
falconindy pushed a commit to falconindy/curl that referenced this pull request Sep 10, 2018
@rikardfalkeborn @falconindy
http_proxy: Remove unused macro SELECT_TIMEOUT
2433902 
Usage was removed in 5113ad0.

Closes curl#2852
falconindy pushed a commit to falconindy/curl that referenced this pull request Sep 10, 2018
@rikardfalkeborn @falconindy
asyn-thread: Remove unused macro
84f2c94 
The macro seems to never have been used.

Closes curl#2852
falconindy pushed a commit to falconindy/curl that referenced this pull request Sep 10, 2018
@rikardfalkeborn @falconindy
test1540: Remove unused macro TEST_HANG_TIMEOUT
d841e00 
The macro has never been used, and it there is not really any place
where it would make sense to add timing checks.

Closes curl#2852
@pps83
Copy link
Contributor

pps83 commented Oct 2, 2018

Perhaps unrelated, but I recently discovered that to my surprise if I post some binary data using libcurl it's posted with application/x-www-form-urlencoded content-type. IMO libcurl shouldn't do that: should either post plain binary or fail and require explicit content-type.

@jay
Copy link
Member

jay commented Oct 3, 2018

Perhaps unrelated, but I recently discovered that to my surprise if I post some binary data using libcurl it's posted with application/x-www-form-urlencoded content-type.

How's it related to this issue? --data-binary doesn't do any processing with the provided data but that does not imply octet stream, as far as I see it.

jay added a commit to jay/curl that referenced this pull request Oct 3, 2018
@jay
data-binary.d: clarify default content-type is x-www-form-urlencoded
4f2358b 
- Advise user that --data-binary sends a default content type of
  x-www-form-urlencoded, and to have the data treated as arbitrary
  binary data by the server set the content-type header to octet-stream.

Ref: curl#2852 (comment)

Closes #xxxx
@jay jay mentioned this pull request Oct 3, 2018
Closed
jay added a commit that referenced this pull request Oct 3, 2018
@jay
data-binary.d: clarify default content-type is x-www-form-urlencoded
f33312f 
- Advise user that --data-binary sends a default content type of
  x-www-form-urlencoded, and to have the data treated as arbitrary
  binary data by the server set the content-type header to octet-stream.

Ref: #2852 (comment)

Closes #3085
@pps83
Copy link
Contributor

pps83 commented Oct 3, 2018 •
edited
Loading

How's it related to this issue? --data-binary doesn't do any processing with the provided data but that does not imply octet stream, as far as I see it.

It's not related, but I noticed that HTTPPOST_CONTENTTYPE_DEFAULT is deleted and I recalled that behavior where libcurl would add x-www-form-urlencoded if I post some binary data.
I would rather prefer that it failed with an error instead of waiting for that moment where my posted binary data suddenly can be trated by the server as url-encoded instead

@lock lock bot locked as resolved and limited conversation to collaborators Jan 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bagder bagder bagder approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rikardfalkeborn @bagder @pps83 @jay