New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add disallow-username-in-url.d and haproxy-protocol.d on the list #2856

Merged
merged 2 commits into from Aug 13, 2018

Conversation

Projects
None yet
2 participants
@kdudka
Collaborator

kdudka commented Aug 9, 2018

... to make make the files appear in distribution tarballs

@bagder

bagder approved these changes Aug 9, 2018

Excellent! We should come up with some way to detect this already in travis... Any idea?

@bagder bagder added the documentation label Aug 9, 2018

kdudka added a commit to kdudka/curl that referenced this pull request Aug 9, 2018

docs: add disallow-username-in-url.d and haproxy-protocol.d on the list
... to make make the files appear in distribution tarballs

Closes #2856

kdudka added a commit to kdudka/curl that referenced this pull request Aug 9, 2018

.travis.yml: verify that man pages can be regenerated
... when curl is built from distribution tarball

Closes #2856
@kdudka

This comment has been minimized.

Show comment
Hide comment
@kdudka

kdudka Aug 9, 2018

Collaborator

I believe that 26a8eea would do the job for us but I am not able to verify it right now because Travis CI for some reason does not see newly created branches on my fork of curl.

Collaborator

kdudka commented Aug 9, 2018

I believe that 26a8eea would do the job for us but I am not able to verify it right now because Travis CI for some reason does not see newly created branches on my fork of curl.

Show outdated Hide outdated .travis.yml
@kdudka

This comment has been minimized.

Show comment
Hide comment
@kdudka

kdudka Aug 10, 2018

Collaborator
Collaborator

kdudka commented Aug 10, 2018

@bagder

This comment has been minimized.

Show comment
Hide comment
@bagder

bagder Aug 10, 2018

Member

Ah yes, you're right!

Member

bagder commented Aug 10, 2018

Ah yes, you're right!

kdudka added a commit to kdudka/curl that referenced this pull request Aug 10, 2018

.travis.yml: verify that man pages can be regenerated
... when curl is built from distribution tarball

Closes #2856
@kdudka

This comment has been minimized.

Show comment
Hide comment
@kdudka

kdudka Aug 10, 2018

Collaborator

I have figured out how to trigger Travis CI jobs when I need to (opening PR against my own fork of curl did the trick). Unfortunately all my jobs, as well as regular upstream jobs, are now failing for unrelated reasons (some apt-get related failures). I will give it another try after the weekend...

Collaborator

kdudka commented Aug 10, 2018

I have figured out how to trigger Travis CI jobs when I need to (opening PR against my own fork of curl did the trick). Unfortunately all my jobs, as well as regular upstream jobs, are now failing for unrelated reasons (some apt-get related failures). I will give it another try after the weekend...

@bagder

This comment has been minimized.

Show comment
Hide comment
@bagder

bagder Aug 10, 2018

Member

We saw those apt failures in some other PRs too today. It looks like travis-side issues.

Member

bagder commented Aug 10, 2018

We saw those apt failures in some other PRs too today. It looks like travis-side issues.

kdudka added a commit to kdudka/curl that referenced this pull request Aug 13, 2018

.travis.yml: verify that man pages can be regenerated
... when curl is built from distribution tarball

Closes #2856

kdudka added a commit to kdudka/curl that referenced this pull request Aug 13, 2018

.travis.yml: verify that man pages can be regenerated
... when curl is built from distribution tarball

Closes #2856

kdudka added some commits Aug 9, 2018

.travis.yml: verify that man pages can be regenerated
... when curl is built from distribution tarball

Closes #2856
docs: add disallow-username-in-url.d and haproxy-protocol.d on the list
... to make make the files appear in distribution tarballs

Closes #2856
@kdudka

This comment has been minimized.

Show comment
Hide comment
@kdudka

kdudka Aug 13, 2018

Collaborator

I think I have updated .travis.yml correctly this time. See how the CI failure looks like:
https://travis-ci.org/kdudka/curl/jobs/415413873#L7400

Collaborator

kdudka commented Aug 13, 2018

I think I have updated .travis.yml correctly this time. See how the CI failure looks like:
https://travis-ci.org/kdudka/curl/jobs/415413873#L7400

@bagder

This comment has been minimized.

Show comment
Hide comment
@bagder

bagder Aug 13, 2018

Member

That looks great!

Member

bagder commented Aug 13, 2018

That looks great!

@kdudka kdudka merged commit 233908a into curl:master Aug 13, 2018

3 of 5 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
LGTM analysis: C/C++ No alert changes
Details
LGTM analysis: Python No alert changes
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@kdudka kdudka deleted the kdudka:docs branch Aug 13, 2018

xquery added a commit to xquery/curl that referenced this pull request Sep 3, 2018

.travis.yml: verify that man pages can be regenerated
... when curl is built from distribution tarball

Closes #2856

xquery added a commit to xquery/curl that referenced this pull request Sep 3, 2018

docs: add disallow-username-in-url.d and haproxy-protocol.d on the list
... to make make the files appear in distribution tarballs

Closes #2856

falconindy added a commit to falconindy/curl that referenced this pull request Sep 10, 2018

.travis.yml: verify that man pages can be regenerated
... when curl is built from distribution tarball

Closes #2856

falconindy added a commit to falconindy/curl that referenced this pull request Sep 10, 2018

docs: add disallow-username-in-url.d and haproxy-protocol.d on the list
... to make make the files appear in distribution tarballs

Closes #2856
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment