Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silence GCC 8 cast-function-type warnings #2860

Closed
wants to merge 2 commits into from

Conversation

MarcelRaad
Copy link
Member

@MarcelRaad MarcelRaad commented Aug 10, 2018

On Windows, casting between unrelated function types is fine and
sometimes even necessary, so just use an intermediate cast to
(void (*) (void)) to silence the warning as described in [0].

[0] https://gcc.gnu.org/onlinedocs/gcc-8.1.0/gcc/Warning-Options.html

bagder
bagder approved these changes Aug 10, 2018
@rikardfalkeborn
Copy link
Contributor

rikardfalkeborn commented Aug 10, 2018

This is the same type of warning that was suppressed in fc3743c. I think it would make sense to silence the warnings the same way (probably by using the new CURLX_FUNCTION_CAST macro)?

@MarcelRaad
Copy link
Member Author

MarcelRaad commented Aug 10, 2018

Thanks, I'll do that!

MarcelRaad added a commit to MarcelRaad/curl that referenced this pull request Aug 10, 2018
Pointed-out-by: Rikard Falkeborn
Closes curl#2860
MarcelRaad added 2 commits Aug 10, 2018
On Windows, casting between unrelated function types is fine and
sometimes even necessary, so just use an intermediate cast to
(void (*) (void)) to silence the warning as described in [0].

[0] https://gcc.gnu.org/onlinedocs/gcc-8.1.0/gcc/Warning-Options.html

Closes curl#2860
Pointed-out-by: Rikard Falkeborn
Closes curl#2860
MarcelRaad added a commit to MarcelRaad/curl that referenced this pull request Aug 11, 2018
Pointed-out-by: Rikard Falkeborn
Closes curl#2860
@MarcelRaad MarcelRaad deleted the gcc8-warnings branch Aug 11, 2018
xquery pushed a commit to xquery/curl that referenced this pull request Sep 3, 2018
On Windows, casting between unrelated function types is fine and
sometimes even necessary, so just use an intermediate cast to
(void (*) (void)) to silence the warning as described in [0].

[0] https://gcc.gnu.org/onlinedocs/gcc-8.1.0/gcc/Warning-Options.html

Closes curl#2860
xquery pushed a commit to xquery/curl that referenced this pull request Sep 3, 2018
Pointed-out-by: Rikard Falkeborn
Closes curl#2860
falconindy pushed a commit to falconindy/curl that referenced this pull request Sep 10, 2018
On Windows, casting between unrelated function types is fine and
sometimes even necessary, so just use an intermediate cast to
(void (*) (void)) to silence the warning as described in [0].

[0] https://gcc.gnu.org/onlinedocs/gcc-8.1.0/gcc/Warning-Options.html

Closes curl#2860
falconindy pushed a commit to falconindy/curl that referenced this pull request Sep 10, 2018
Pointed-out-by: Rikard Falkeborn
Closes curl#2860
@lock lock bot locked as resolved and limited conversation to collaborators Nov 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants