New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows/checksrc: improve search for perl #2865

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@djelinski
Contributor

djelinski commented Aug 10, 2018

because I had perl installed with git, and the original code couldn't find it.

@djelinski djelinski force-pushed the djelinski:checksrc branch from a21b3d9 to e940d89 Aug 10, 2018

jay added a commit that referenced this pull request Aug 11, 2018

projects: Improve Windows perl detection in batch scripts
- Determine if perl is in the user's PATH by running perl.exe.

Prior to this change detection was done by checking the PATH for perl/
but that did not work in all cases (eg git install includes perl but
not in perl/ path).

Bug: #2865
Reported-by: Daniel Jeliński
@jay

This comment has been minimized.

Member

jay commented Aug 11, 2018

XP doesn't have where so I changed it to perl --version to check if perl is in the path. Thanks, landed in 220cd24.

@jay jay closed this Aug 11, 2018

xquery added a commit to xquery/curl that referenced this pull request Sep 3, 2018

projects: Improve Windows perl detection in batch scripts
- Determine if perl is in the user's PATH by running perl.exe.

Prior to this change detection was done by checking the PATH for perl/
but that did not work in all cases (eg git install includes perl but
not in perl/ path).

Bug: curl#2865
Reported-by: Daniel Jeliński

falconindy added a commit to falconindy/curl that referenced this pull request Sep 10, 2018

projects: Improve Windows perl detection in batch scripts
- Determine if perl is in the user's PATH by running perl.exe.

Prior to this change detection was done by checking the PATH for perl/
but that did not work in all cases (eg git install includes perl but
not in perl/ path).

Bug: curl#2865
Reported-by: Daniel Jeliński

@lock lock bot locked as resolved and limited conversation to collaborators Nov 9, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.