Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ssh-libssh: fix infinite connect loop on invalid private key #2879

Closed
wants to merge 2 commits into from

Conversation

@kdudka
Copy link
Collaborator

kdudka commented Aug 14, 2018

Added test 656 (based on test 604) to verify the fix.

Bug: https://bugzilla.redhat.com/1595135

kdudka added 2 commits Aug 14, 2018
Added test 656 (based on test 604) to verify the fix.

Bug: https://bugzilla.redhat.com/1595135
The verbose message "Authentication using SSH public key file" was
printed each time the ssh_userauth_publickey_auto() was called, which
meant each time a packet was transferred over network because the API
operates in non-blocking mode.

This patch makes sure that the verbose message is printed just once
(when the authentication state is entered by the SSH state machine).
@kdudka kdudka force-pushed the kdudka:libssh branch from 2b58448 to 74c6781 Aug 14, 2018
@bagder
bagder approved these changes Aug 14, 2018
@bagder
bagder approved these changes Aug 14, 2018
@kdudka kdudka closed this in a4c7911 Aug 14, 2018
@kdudka kdudka deleted the kdudka:libssh branch Aug 14, 2018
xquery added a commit to xquery/curl that referenced this pull request Sep 3, 2018
falconindy added a commit to falconindy/curl that referenced this pull request Sep 10, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Nov 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants
You can’t perform that action at this time.