Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CURLOPT_UPLOAD_BUFFERSIZE: set upload buffer size #2896

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
2 participants
@bagder
Copy link
Member

commented Aug 18, 2018

This is step 3 of #2888.

Fixes #2888

@bagder

This comment has been minimized.

Copy link
Member Author

commented Aug 21, 2018

When this lands, we can also consider upping the size that the curl tool uses - since it only does one handle at a time it can easily afford using a larger buffer.

@danielgustafsson
Copy link
Member

left a comment

LGTM, one small typo found

This is just treated as a request, not an order. You cannot be guaranteed to
actually get the given size.

The ulpoad buffer size is by default 64 kilobytes. The maximum buffer size

This comment has been minimized.

Copy link
@danielgustafsson

danielgustafsson Sep 3, 2018

Member

s/ulpoad/upload/

@bagder bagder force-pushed the bagder/CURLOPT_UPLOAD_BUFFERSIZE branch from 4910cea to 23e421b Sep 3, 2018

@bagder

This comment has been minimized.

Copy link
Member Author

commented Sep 3, 2018

Thanks, fixed that and rebased.

@bagder bagder closed this in 2825f46 Sep 6, 2018

@bagder bagder deleted the bagder/CURLOPT_UPLOAD_BUFFERSIZE branch Sep 6, 2018

falconindy added a commit to falconindy/curl that referenced this pull request Sep 10, 2018

@lock lock bot locked as resolved and limited conversation to collaborators Dec 5, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.