Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upCURLOPT_UPLOAD_BUFFERSIZE: set upload buffer size #2896
+115
−17
Conversation
bagder
added
next-feature-window
performance
labels
Aug 18, 2018
This comment has been minimized.
This comment has been minimized.
|
When this lands, we can also consider upping the size that the curl tool uses - since it only does one handle at a time it can easily afford using a larger buffer. |
| This is just treated as a request, not an order. You cannot be guaranteed to | ||
| actually get the given size. | ||
|
|
||
| The ulpoad buffer size is by default 64 kilobytes. The maximum buffer size |
This comment has been minimized.
This comment has been minimized.
bagder
force-pushed the
bagder/CURLOPT_UPLOAD_BUFFERSIZE
branch
from
4910cea
to
23e421b
Sep 3, 2018
This comment has been minimized.
This comment has been minimized.
|
Thanks, fixed that and rebased. |
bagder
removed
the
next-feature-window
label
Sep 6, 2018
bagder
closed this
in
2825f46
Sep 6, 2018
bagder
deleted the
bagder/CURLOPT_UPLOAD_BUFFERSIZE
branch
Sep 6, 2018
falconindy
added a commit
to falconindy/curl
that referenced
this pull request
Sep 10, 2018
lock
bot
locked as resolved and limited conversation to collaborators
Dec 5, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
bagder commentedAug 18, 2018
This is step 3 of #2888.
Fixes #2888