Do not translate ?' to %09' for GOPHER
#2910
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since GOPHER support was added in curl `?' character was automatically translated to `%09' (`\t'). However, this behaviour does not seems documented in RFC 4266 and for search selectors it is documented to directly use `%09' in the URL. Apart that several gopher servers in the current gopherspace have CGI support where `?' is used as part of the selector and translating it to `%09' often leads to surprising results.
|
I can't explain it. It came already in the commit 201637d that brought (back) gopher support to curl back in 2010... |
bagder
approved these changes
Aug 23, 2018
|
Thanks! |
|
Hello Daniel,
Daniel Stenberg writes:
Thanks!
Thank you very much for quickly applying it!
Keep up the good work!
|
falconindy
pushed a commit
to falconindy/curl
that referenced
this pull request
Sep 10, 2018
Since GOPHER support was added in curl `?' character was automatically translated to `%09' (`\t'). However, this behaviour does not seems documented in RFC 4266 and for search selectors it is documented to directly use `%09' in the URL. Apart that several gopher servers in the current gopherspace have CGI support where `?' is used as part of the selector and translating it to `%09' often leads to surprising results. Closes curl#2910
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have tried to dig in the lib/gopher.c history but unfortunately
apart the comment I was not able to find other rationales regarding
the
?->%09translation. AFAIK RFC 1436 predates URIs but RFC4266 - that standardize gopher:// URIs does not contain any note
regarding a possible
?->%09translation and also in "Section2.1 Gopher URL Syntax" for the search types it is documented to
just use
%09to separate<selector>and<search>fields.At least geomyidae, PyGopherd and bucktooth supports CGI where the
?character is used and it is pretty common to find that in thecurrent gopherspace. Translating
?to%09leads to surprisingresults in these cases.
Thank you!
EDIT: Adjusted formatting (NFC)