Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cookies: Remove redundant expired check #2962

Closed

Conversation

@danielgustafsson
Copy link
Member

commented Sep 9, 2018

Expired cookies have already been purged with a later expiration time before this check via remove_expired(), so remove the redundant check.

cookies: Remove redundant expired check
Expired cookies have already been purged at a later expiration time
before this check, so remove the redundant check.
@bagder
bagder approved these changes Sep 9, 2018
Copy link
Member

left a comment

good catch!

@bagder

This comment has been minimized.

Copy link
Member

commented Sep 10, 2018

Thanks!

@bagder bagder closed this in c3654df Sep 10, 2018

falconindy added a commit to falconindy/curl that referenced this pull request Sep 10, 2018
cookies: Remove redundant expired check
Expired cookies have already been purged at a later expiration time
before this check, so remove the redundant check.

closes curl#2962

@lock lock bot locked as resolved and limited conversation to collaborators Dec 9, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants
You can’t perform that action at this time.