Repository navigation
ntlm_wb: Fix memory leaks in ntlm_wb_response errorcases - #2966
Closed
danielgustafsson wants to merge 2 commits into
Closed
danielgustafsson wants to merge 2 commits into
danielgustafsson wants to merge 2 commits into
Conversation
bagder
approved these changes
Sep 10, 2018
When erroring out on either realloc failure, or a request being too large, the existing buffer was leaked. Fix by adding a fail clause and free the buffer on the way out. Closes: curl#2966 Reviewed-by: Daniel Stenberg <daniel@haxx.se>
danielgustafsson
force-pushed
the
dg-ntlm_leak
branch
from
September 11, 2018 10:41
efe4b2f to
69acd9f
Compare
Contributor
Author
|
This patch was actually wrong, it erroneously introduced a double-free on |
Contributor
Author
|
None of the errors are related to the PR in question, seems mostly relate to Github flakiness |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When erroring out on either realloc failure, or a request being too large the existing buffer was leaked. Fix by adding a fail clause and free the buffer on the way out.