New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ftp: Ensure to include command in Curl_ftpsend() sendbuffer #2985

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@danielgustafsson
Member

danielgustafsson commented Sep 12, 2018

Commit 8238ba9 inadvertently removed the actual command to be sent from the send buffer in a refactoring. Add back copying the command into the buffer. Also add more guards against malformed input while at it. There seems to be a lack of testing of this module, but I'm not really sure how to improve that right now so I'll leave that for another PR.

Also comes with a bonus tiny memleak fix in krb5.c which was the original reason for spotting this.

danielgustafsson added some commits Sep 12, 2018

ftp: include command in Curl_ftpsend sendbuffer
Commit 8238ba9 inadvertently removed
the actual command to be sent from the send buffer in a refactoring.
Add back copying the command into the buffer. Also add more guards
against malformed input while at it.
krb5: fix memory leak in krb_auth
The FTP command allocated by aprintf() must be freed after usage.
@bagder

bagder approved these changes Sep 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment