Skip to content

/curl

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sendf: use macro indirection and ensure concatenation has whitespace #2986

Closed
wants to merge 2 commits into from

Conversation

@danielgustafsson
Copy link
Member

commented Sep 12, 2018

Two small infof()/failf() related fixups that I happened to note when skimming code. There were two callsites using the function names rather than the macro indirection, and two infof() strings which lacked proper whitespace in the concatenation.
@danielgustafsson
sendf: Fix whitespace in infof/failf concatenation 
Strings broken on multiple rows in the .c file need to have appropriate
whitespace padding on either side of the concatenation point to render
a correct amalgamated string. Fix by adding a space at the occurrences
found.
377d654
@danielgustafsson
sendf: use failf() rather than Curl_failf() 
The failf() macro is the name used for invoking Curl_failf(). While
there isn't a way to turn off failf like there is for infof, but it's
still a good idea to use the macro.
Loading status checks…
a10ef66
@bagder
bagder approved these changes Sep 13, 2018
View changes

@danielgustafsson danielgustafsson closed this in e7ee2f2 Sep 13, 2018

@lock lock bot locked as resolved and limited conversation to collaborators Dec 12, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bagder bagder

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@danielgustafsson @bagder
You can’t perform that action at this time.