Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nss: try to connect even if libnssckbi.so fails to load #3016

Closed
wants to merge 1 commit into from

Conversation

@kdudka
Copy link
Collaborator

commented Sep 19, 2018

One can still use CA certificates stored in NSS database.

Reported-by: Maxime Legros
Bug: https://curl.haxx.se/mail/lib-2018-09/0077.html

nss: try to connect even if libnssckbi.so fails to load
One can still use CA certificates stored in NSS database.

Reported-by: Maxime Legros
Bug: https://curl.haxx.se/mail/lib-2018-09/0077.html
@bagder
bagder approved these changes Sep 19, 2018
Copy link
Member

left a comment

Makes sense!

@kdudka kdudka closed this in eb0b3ac Sep 19, 2018

@kdudka kdudka deleted the kdudka:nss-trust branch Sep 19, 2018

@jay

This comment has been minimized.

Copy link
Member

commented Sep 19, 2018

Does this fix the entire bug, if the module names are hardcoded shouldn't it be ifdef'd so that WIN32 uses .dll instead of .so

@kdudka

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 20, 2018

Yes, that is an orthogonal issue. Note that according to https://curl.haxx.se/mail/lib-2018-09/0077.html it is not just the .dll vs. .so suffix but also the lib prefix. Whether or not all Windows distributions of NSS use the same names for shared libraries is, however, not clear from that bug report and I have no way to experiment with that.

jay added a commit to jay/curl that referenced this pull request Oct 3, 2018
nss: fix nssckbi module loading on Windows
- Use .DLL extension instead of .so to load modules on Windows.

Bug: https://curl.haxx.se/mail/lib-2018-09/0077.html
Reported-by: Maxime Legros

Ref: curl#3016

Closes #xxxx
jay added a commit that referenced this pull request Oct 3, 2018
nss: fix nssckbi module loading on Windows
- Use .DLL extension instead of .so to load modules on Windows.

Bug: https://curl.haxx.se/mail/lib-2018-09/0077.html
Reported-by: Maxime Legros

Ref: #3016

Closes #3086

@lock lock bot locked as resolved and limited conversation to collaborators Dec 19, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can’t perform that action at this time.