New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake: disable -Wpedantic-ms-format #3120

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@MarcelRaad
Member

MarcelRaad commented Oct 9, 2018

As done in the autotools build. This is required for MinGW, which
supports only %I64 for printing 64-bit values, but warns about it.

Closes

CMake: disable -Wpedantic-ms-format
As done in the autotools build. This is required for MinGW, which
supports only %I64 for printing 64-bit values, but warns about it.

Closes
@bagder

bagder approved these changes Oct 10, 2018

@MarcelRaad MarcelRaad deleted the MarcelRaad:cmake_mingw_warning branch Oct 10, 2018

@vszakats

This comment has been minimized.

Member

vszakats commented Oct 10, 2018

Just a minor nit that I noticed too late: an invisible UTF-8 BOM character slipped into the file.

@MarcelRaad

This comment has been minimized.

Member

MarcelRaad commented Oct 10, 2018

Oh no, how could that happen again? Thanks, I'll fix this tomorrow morning.

MarcelRaad added a commit that referenced this pull request Oct 11, 2018

CMake: remove BOM
Accidentally aded in commit 1bb8605.

Reported-by: Viktor Szakats
Ref: #3120 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment