Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

travis: make distcheck scan for BOM markers #3126

wants to merge 3 commits into from


Copy link

@bagder bagder commented Oct 11, 2018

No description provided.

@bagder bagder added the build label Oct 11, 2018
bagder referenced this pull request Oct 11, 2018
Accidentally aded in commit 1bb8605.

Reported-by: Viktor Szakats
Ref: #3120 (comment)
Copy link
Member Author

bagder commented Oct 11, 2018

projects/wolfssl_override.props is an XML file in our git tree that has a BOM so this check should find that one and error out.

If we think that file should keep its BOM we need to do some whitelisting.

Copy link
Member Author

bagder commented Oct 11, 2018

It found the BOM fine and failed the build. Now I'm removing the BOM from there and this should now succeed...

Copy link

@danielgustafsson danielgustafsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


@bagder bagder closed this in a47a264 Oct 12, 2018
@bagder bagder deleted the bagder/travis-BOM-scan branch October 12, 2018 06:50
@lock lock bot locked as resolved and limited conversation to collaborators Jan 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Successfully merging this pull request may close these issues.

None yet

2 participants