tool_cb_hdr: handle failure of rename()#3140
Merged
kdudka merged 1 commit intocurl:masterfrom Oct 17, 2018
Merged
Conversation
Member
|
In the case of failure outs->filename is freed but then never reassigned to so couldn't that lead to a double free, I suggest change it to Curl_safefree instead. Also braces for the if warnf since it spans more than one line. |
Detected by Coverity. Closes curl#3140 Reviewed-by: Jay Satiro
kdudka
force-pushed
the
rename-failure
branch
from
d84b547 to
6b6ba1d
Compare
Contributor
Author
|
@jay Thanks for review! PR updated... |
bagder
approved these changes
Oct 17, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Detected by Coverity.