Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

travis: add build for "configure --disable-verbose" #3144

Closed
wants to merge 7 commits into from
Closed

travis: add build for "configure --disable-verbose" #3144

wants to merge 7 commits into from

Conversation

bagder
Copy link
Member

@bagder bagder commented Oct 16, 2018

No description provided.

@bagder bagder added the build label Oct 16, 2018
@bagder bagder mentioned this pull request Oct 16, 2018
Closed
@bagder
Copy link
Member Author

bagder commented Oct 17, 2018

Interestingly, Travis gets an error that I didn't (or missed):

In file included from file.c:55:0:
sendf.h:35:15: error: anonymous variadic macros were introduced in C99 [-Werror=variadic-macros]
 #define infof(...)  Curl_nop_stmt
               ^

@bagder
Copy link
Member Author

bagder commented Oct 17, 2018 •
edited

Disabling verbose really needs vararg macro support (to "remove" the infof() calls) which C89 didn't offer, so I'm inclined to just switch off the warning for this build.

MarcelRaad
MarcelRaad approved these changes Oct 18, 2018
View reviewed changes
Copy link
Member

@MarcelRaad MarcelRaad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do the 5XX tests fail so often on AppVeyor… :-(

@bagder
Copy link
Member Author

bagder commented Oct 18, 2018

Very annoying yeah 👎

@bagder bagder closed this in ad547fc Oct 18, 2018
@bagder bagder deleted the bagder/travis-disable-verbose branch October 18, 2018 12:52
@lock lock bot locked as resolved and limited conversation to collaborators Jan 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MarcelRaad MarcelRaad MarcelRaad approved these changes

Assignees
No one assigned
Labels
build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bagder @MarcelRaad