Skip to content

travis: sanitize=address,undefined,signed-integer-overflow - #3190

Closed
bagder wants to merge 1 commit into
masterfrom
bagder/travis-san-clang
Closed

bagder wants to merge 1 commit into
masterfrom
bagder/travis-san-clang

Conversation

@bagder

@bagder bagder commented Oct 29, 2018

Copy link
Copy Markdown
Member

... using clang

@bagder bagder added the build label Oct 29, 2018
@bagder bagder changed the title travis: add build doing sanitize=address,undefined,signed-integer-ove… travis: sanitize=address,undefined,signed-integer-overflow Oct 29, 2018
@bagder

bagder commented Oct 31, 2018

Copy link
Copy Markdown
Member Author

I don't understand this error, nor do I understand why it build nghttp2 again here since it is supposed to be cached... :-/

@MarcelRaad

Copy link
Copy Markdown
Member

Mixing clang and GCC also doesn't look right, does it?

      C compiler:     clang
      CFLAGS:         -fsanitize=address,undefined,signed-integer-overflow -fno-sanitize-recover=undefined,integer -Wformat -Werror=format-security -Werror=array-bounds -g
      LDFLAGS:        -fsanitize=address,undefined -fno-sanitize-recover=undefined,integer
      C++ compiler:   g++-8
      CXXFLAGS:       -g -O2
      CXXCPP:         g++-8 -E
      C preprocessor: clang -E

@bagder

bagder commented Oct 31, 2018

Copy link
Copy Markdown
Member Author

Exactly, that's the side-effect of nghttp2 getting built (again) with the setup that is meant only for the curl build. I tried to setup so that the nghttp2 build would remain cached and thus not having to get rebuilt so that the CFLAGS + clang settings wouldn't be used in the nghttp2 build...

@MarcelRaad

MarcelRaad commented Oct 31, 2018

Copy link
Copy Markdown
Member

Ah, you want to reuse the build from previous jobs? Aren't the builds run in parallel on different machines? I thought any caching was only best-effort, but maybe I don't understand how Travis works well enough yet.

@bagder

bagder commented Oct 31, 2018

Copy link
Copy Markdown
Member Author

right, well obviously it didn't work so I need to come up with a way that makes the sanitizer stuff only affect the curl build and not the other ones...

@MarcelRaad

MarcelRaad commented Oct 31, 2018

Copy link
Copy Markdown
Member

CXX="g++-8" CC="gcc-8" CFLAGS="" LDFLAGS="" LIBS="" ./configure maybe for nghttp2 etc.?

@bagder
bagder force-pushed the bagder/travis-san-clang branch from c2804a1 to 7df8563 Compare October 31, 2018 12:53
@bagder

bagder commented Oct 31, 2018

Copy link
Copy Markdown
Member Author

Excellent suggestion. Rebased and squashed to make it easier to review.

@bagder bagder closed this in 58d0425 Nov 1, 2018
@bagder
bagder deleted the bagder/travis-san-clang branch November 1, 2018 08:45
@lock lock Bot locked as resolved and limited conversation to collaborators Jan 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Development

Successfully merging this pull request may close these issues.

2 participants