/ curl Public
configure: include all libraries in ssl-libs fetch #3193
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge.
When compiling a collection of SSL libraries to link against (SSL_LIBS), ensure all libraries are included. The call
--libs-only-lcan produce only a subset of found in a
--libscall (e.x. pthread may be excluded). Adding
--libs-only-otherensures other libraries are also included in the list. This corrects select build environments compiling against a static version of OpenSSL. Before the change, the following could be observed:
And include the other libraries when compiling SSL_LIBS succeeds with:
This issue was observed in an environment where OpenSSL package (v1.1.1) was being built as a static-only library (
./config no-dso no-shared ...). Adding the option
--libs-only-otherto the pkg-config check allowed libcurl to build with (at least) the following options set:
And the following environment variables set:
It is assumed the introduction of the argument
--libs-only-otheris not an issue since it has been available in
pkg-configsince v0.24 (~8 years ago).
This may also relate to #567.