Conversation
... revert the mistaken change brought in commit 8440616. Reported-by: Alessandro Ghedini Bug: https://curl.haxx.se/mail/lib-2018-10/0118.html
MarcelRaad
approved these changes
Oct 31, 2018
MarcelRaad
left a comment
MarcelRaad
left a comment
Member
There was a problem hiding this comment.
Ah! I was just wondering about that too when I tried to build on a fresh machine without curl.
Member
Author
|
I'm thinking of trying removing the curl tool from the travis image before the tests are run, to make sure this kind of mistake will be caught in the future... |
bagder
added a commit
that referenced
this pull request
Oct 31, 2018
... to make sure the test suite runs with its newly build tool! Bug: #3198
bagder
added a commit
that referenced
this pull request
Nov 1, 2018
... to make sure the test suite runs with its newly build tool! Bug: #3198
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... revert the mistaken change brought in commit 8440616.
Reported-by: Alessandro Ghedini
Bug: https://curl.haxx.se/mail/lib-2018-10/0118.html