New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtests: use the local curl for verifying #3198

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@bagder
Member

bagder commented Oct 31, 2018

... revert the mistaken change brought in commit 8440616.

Reported-by: Alessandro Ghedini
Bug: https://curl.haxx.se/mail/lib-2018-10/0118.html

runtests: use the local curl for verifying
... revert the mistaken change brought in commit 8440616.

Reported-by: Alessandro Ghedini
Bug: https://curl.haxx.se/mail/lib-2018-10/0118.html
@MarcelRaad

Ah! I was just wondering about that too when I tried to build on a fresh machine without curl.

@bagder

This comment has been minimized.

Member

bagder commented Oct 31, 2018

I'm thinking of trying removing the curl tool from the travis image before the tests are run, to make sure this kind of mistake will be caught in the future...

bagder added a commit that referenced this pull request Oct 31, 2018

travis: remove curl before a normal build
... to make sure the test suite runs with its newly build tool!

Bug: #3198

@bagder bagder closed this in 8effa8c Oct 31, 2018

@bagder bagder deleted the bagder/runtests-vcurl branch Oct 31, 2018

bagder added a commit that referenced this pull request Nov 1, 2018

travis: remove curl before a normal build
... to make sure the test suite runs with its newly build tool!

Bug: #3198

xquery added a commit to xquery/curl that referenced this pull request Nov 1, 2018

runtests: use the local curl for verifying
... revert the mistaken change brought in commit 8440616.

Reported-by: Alessandro Ghedini
Bug: https://curl.haxx.se/mail/lib-2018-10/0118.html

Closes curl#3198

bagder added a commit that referenced this pull request Nov 2, 2018

travis: remove curl before a normal build
on Linux. To make sure the test suite runs with its newly build tool and
doesn't require an external one present.

Bug: #3198
Closes #3200
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment