Avoid two unsigned int overflows in FTP listing parser #3225
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Curl_ftp_parselist: avoid unsigned integer overflows detected by clang
The overflow has no real world impact.
Just avoid it for "best practice".
Details
ftplistparser.c:
With any input and first char no being a digit (0-9), the execution
goes straight to L408. This results in the 'unsigned int overflow'.
Then the execution goes straight to L1007 which causes the second
'unsigned int overflow'.
A simple 'continue' in L408 instead of 'i--' avoids both warnings.