New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESCape "\n" codes #3246

Merged
merged 1 commit into from Nov 9, 2018

Conversation

Projects
None yet
3 participants
@gvanem
Member

gvanem commented Nov 7, 2018

In a .nf section, Groff / Troff will display a:

 printf("Errno: %ld\n", error);

as:

  printf("Errno: %ld0, error);

when a "\n" is not escaped. Use "\\n" instead.

@bagder

The change looks fine, but please make your commit message follow our standard style. Perhaps:

 CURLINFO_OS_ERRNO.3: escape "\n" codes

@gvanem gvanem changed the title from ESCape "\n" codes to CURLINFO_OS_ERRNO.3: ESCape "\n" codes Nov 7, 2018

@gvanem gvanem changed the title from CURLINFO_OS_ERRNO.3: ESCape "\n" codes to CURLOPT_CHUNK_BGN_FUNCTION.3: ESCape "\n" codes Nov 7, 2018

@gvanem gvanem changed the title from CURLOPT_CHUNK_BGN_FUNCTION.3: ESCape "\n" codes to ESCape "\n" codes Nov 7, 2018

@gvanem

This comment has been minimized.

Member

gvanem commented Nov 7, 2018

Too late to edit the commit message now. Only the title is editable. At least here on Github.

@bagder

This comment has been minimized.

Member

bagder commented Nov 7, 2018

You can always edit the commits in your branch (git rebase -i) and then force-push them to the branch. But once they're merged to master it is too late.

@gvanem

This comment has been minimized.

Member

gvanem commented Nov 7, 2018

There's an option here on Github for a Create a merge commit. But it's disabled for curl:
curl_rebase_mergel

So I'm not sure what to do. Or what you want me to do about this PR.

@kdudka

This comment has been minimized.

Collaborator

kdudka commented Nov 7, 2018

@gvanem git rebase -i is a command that you need to run in a terminal.

@gvanem

This comment has been minimized.

Member

gvanem commented Nov 8, 2018

@kdudka I know that. But it's a big hassle for me to git pull , edit, commit and push just for this small change. That's why I did it all here at Github (it was easier to contribute to libcurl in the old pre-git days).

docs: ESCape "\n" codes
Groff / Troff will display a:
 printaf("Errno: %ld\n", error);
as:
  printf("Errno: %ld0, error);

when a "\n" is not escaped. Use "\\n" instead.

Closes #3246

@bagder bagder force-pushed the escape-codes-docs branch from 1193789 to 073332b Nov 9, 2018

@bagder

This comment has been minimized.

Member

bagder commented Nov 9, 2018

I disagree with that, but perhaps the biggest change and improvement compared to the "old days" and now is that we run a bazillion tests on the change before we merge it...

I squashed and forced-pushed these commits with a new commit message!

@bagder bagder merged commit 073332b into master Nov 9, 2018

2 of 7 checks passed

buildbot/curl-unthreaded-solaris10-i386 Build started.
Details
buildbot/curl-unthreaded-solaris10-sparc Build started.
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
LGTM analysis: C/C++ No code changes detected
Details
LGTM analysis: Python No code changes detected
Details

@bagder bagder deleted the escape-codes-docs branch Nov 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment