Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
Did you test it? If I read the code correctly, the proposed change is a no-op. libcurl on top of NSS defaults to NSS' default min/max versions of TLS.
There seems to be one place that needs to be updated for the
Yeps. Before my patch: curl fails as #3261 describes. After patch: that command line works...
I beg to differ. The non-patch version sets 1.0 to be the max version by default here:
... so when we raise the minimum to 1.2 with the option, the call to
If you have a better/more appropriate fix, I'll happily accept that! =)
Sorry, I overlooked commit 2e5651a which had actually triggered this bug (allowing to set
The code I was talking about is actually dead code now and it can be safely removed: