Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: add support to test against OpenSSH for Windows #3290

Merged
merged 1 commit into from May 22, 2019

Conversation

@mback2k
Copy link
Member

commented Nov 19, 2018

This a work-in-process pull-request to get the testsuite work with OpenSSH for Windows.

This pull-request is not complete and only open to trigger the CI tests.

@mback2k mback2k self-assigned this Nov 19, 2018
@mback2k mback2k force-pushed the mback2k:tests-openssh-for-windows branch from bddd140 to 3a0490f Nov 20, 2018
@bagder
bagder approved these changes Nov 20, 2018
@mback2k mback2k force-pushed the mback2k:tests-openssh-for-windows branch 2 times, most recently from be19688 to bf0f7e1 Dec 3, 2018
@bagder

This comment has been minimized.

Copy link
Member

commented May 11, 2019

@mback2k what's the plan here? It's been here for a long time and seemed to be fine until the merge conflict appeared. Is this still worth doing?

@mback2k

This comment has been minimized.

Copy link
Member Author

commented May 11, 2019

@bagder I will get back to this, yes. It wasn't completely working on all my buildbots yet, I will try to fix the merge conflict and make it work on all versions of MinGW/msys.

@mback2k mback2k force-pushed the mback2k:tests-openssh-for-windows branch from 6b55977 to b9f8937 May 18, 2019
@mback2k mback2k changed the title tests: add support to test against OpenSSH for Windows (WIP) tests: add support to test against OpenSSH for Windows May 18, 2019
@mback2k

This comment has been minimized.

Copy link
Member Author

commented May 18, 2019

@bagder I think this PR is ready to be merged once all checks have passed. Does this have to wait until the release or can it go into master during the freeze?

@bagder

This comment has been minimized.

Copy link
Member

commented May 18, 2019

Since it has been waiting for this long, I think it won't harm much if we take it the safe route and wait with the merge until after Wednesday. There's so little time left I figure it might not be worth rocking the boat now... I'm not sure how to estimate how safe/risky this change is so I rather we play it safe.

Testing against OpenSSH for Windows requires v7.7.0.0 or newer
due to the use of AllowUsers and DenyUsers. For more info see:
https://github.com/PowerShell/Win32-OpenSSH/wiki/sshd_config
@mback2k mback2k force-pushed the mback2k:tests-openssh-for-windows branch from b9f8937 to 081d374 May 22, 2019
@mback2k mback2k merged commit 081d374 into curl:master May 22, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Aug 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants
You can’t perform that action at this time.