Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of deprecated CURLE_SSL_CACERT and improve documentation #3291

Closed
wants to merge 3 commits into from

Conversation

@sweatybridge
Copy link
Contributor

@sweatybridge sweatybridge commented Nov 20, 2018

No description provided.

bagder
bagder approved these changes Nov 20, 2018
@bagder
Copy link
Member

@bagder bagder commented Nov 20, 2018

Thanks!

@bagder bagder closed this in 78ff4e0 Nov 20, 2018
mback2k
Copy link
Member

mback2k commented on 0fd4427 Nov 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change together with 53d137d causes my legacy Pidgin plugin builds to fail. Was it intentional to have CURL_NO_OLDIES defined by default?

bagder
Copy link
Member

bagder commented on 0fd4427 Nov 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Internally we should have it defined but it should not be set in any public header file. But I can't detect that being true? How does this break the plugin?

mback2k
Copy link
Member

mback2k commented on 0fd4427 Nov 25, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind, this build error was later fixed by 78ff4e0.

@lock lock bot locked as resolved and limited conversation to collaborators Feb 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants