New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake: fix MIT/Heimdal Kerberos detection #3316

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@chpock
Contributor

chpock commented Nov 27, 2018

  • fix syntax error in FindGSS.cmake
  • correct krb5 include directory. FindGSS exports
    "GSS_INCLUDE_DIR" variable.
CMake: fix MIT/Heimdal Kerberos detection
- fix syntax error in FindGSS.cmake
- correct krb5 include directory. FindGSS exports
"GSS_INCLUDE_DIR" variable.
@jay

This comment has been minimized.

Member

jay commented Nov 28, 2018

@jzakrzewski can you review, also should we be sending these changes upstream somewhere or is this exclusively curl? And what is this comment:

if(_GSS_INCLUDE_DIR) #jay, we've found something

@jzakrzewski

This comment has been minimized.

Contributor

jzakrzewski commented Nov 28, 2018

@jay I'm pretty sure I've found the base version of it roaming somewhere on the Internet or compiled it somehow (I have, ofc, checked the licence back then and complied as I always do). But there are some curl-specific modification (the comments about autotools are mine I guess). Right now many versions of this one can find on the net come from various copies of curl. So I don't believe there's "upstream" for it.

The comment looks a bit like something I could have written (you wouldn't believe what I leave in my company's code sometimes ;) ). It only expresses joy that we've got GSS :D

As for the changes - they look correct. I haven't build curl with GSS for a longer while but it seems it must have been quite broken since 4d60e12 (and the spaces in find module were indeed missing, probably causing some warnings).
Travis error is unrelated.

@jay jay closed this in a39d8f7 Nov 29, 2018

@jay

This comment has been minimized.

Member

jay commented Nov 29, 2018

Thanks guys

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment