Some fixes for curl_global_sslset() when built with a single SSL backend
#3346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dscho
commented
Dec 6, 2018
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
It is allowed to call that function with id set to -1, specifying the backend by the name instead. We should imitate what is done further down in that function to allow for that. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
When compiled with a single SSL backend, Curl_ssl is never set to Curl_ssl_multi, but to that single backend from the beginning. When the caller tries to set the SSL backend to a different backend than the one that was compiled in, in this scenario we should not say that it is too late to set the SSL backend, but that it is an unknown backend to begin with. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho
force-pushed
the
ssl-backend-fixes
branch
from
1901970
to
639f6f7
Compare
bagder
approved these changes
Dec 7, 2018
|
Thanks! |
|
@bagder thank you so much! I would also like to take a moment to thank you for being an excellent open source maintainer. You know, I strive to imitate you in your welcoming, gentle and inviting manners? |
|
Thank you. It is certainly good to know that my efforts pay off. Getting praise from equals is the highest form of flattery I can imagine! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
While working on #3345, I realized that there were a couple of issues with the
curl_global_sslset()when built with a single SSL backend, resulting in an incorrect error messages in one case, and in another case an error when we should have succeeded.This PR fixes both issues.