(lib)curl.rc: fixup for minor bugs #3348
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All resources defined in lib/libcurl.rc and curl.rc are language neutral winbuild/MakefileBuild.vc ALWAYS defines the macro DEBUGBUILD, so the replace the hard-coded constants in both *.rc files with #define'd values URL: https://curl.haxx.se/mail/lib-2018-11/0000.html
|
This is a patch provided by Stefan. I have no way to judge these changes so I'll appreciate a 👍 or 👎 from someone who do know... |
|
Looks OK but I don't feel qualified to +1 this... |
This part is missing from the commit message. Otherwise, this PR looks good to me. |
Right, thanks. I used |
|
Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All resources defined in lib/libcurl.rc and curl.rc are language neutral
winbuild/MakefileBuild.vc ALWAYS defines the macro DEBUGBUILD, so the ifdef's in line 33 of lib/libcurl.rc and src/curl.rc are wrong
replace the hard-coded constants in both *.rc files with #define'd
values
URL: https://curl.haxx.se/mail/lib-2018-11/0000.html
(This is from an old email from Stefan Kanthak that seems to not have been addressed...)