Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(lib)curl.rc: fixup for minor bugs #3348

Closed
wants to merge 1 commit into from

Conversation

@bagder
Copy link
Member

commented Dec 7, 2018

All resources defined in lib/libcurl.rc and curl.rc are language neutral

winbuild/MakefileBuild.vc ALWAYS defines the macro DEBUGBUILD, so the ifdef's in line 33 of lib/libcurl.rc and src/curl.rc are wrong

replace the hard-coded constants in both *.rc files with #define'd
values

URL: https://curl.haxx.se/mail/lib-2018-11/0000.html

(This is from an old email from Stefan Kanthak that seems to not have been addressed...)

(lib)curl.rc: fixup for minor bugs
All resources defined in lib/libcurl.rc and curl.rc are language neutral

winbuild/MakefileBuild.vc ALWAYS defines the macro DEBUGBUILD, so the

replace the hard-coded constants in both *.rc files with #define'd
values

URL: https://curl.haxx.se/mail/lib-2018-11/0000.html
@bagder

This comment has been minimized.

Copy link
Member Author

commented Dec 7, 2018

This is a patch provided by Stefan. I have no way to judge these changes so I'll appreciate a 👍 or 👎 from someone who do know...

@rodwiddowson

This comment has been minimized.

Copy link
Contributor

commented Dec 8, 2018

Looks OK but I don't feel qualified to +1 this...

@dscho

This comment has been minimized.

Copy link
Contributor

commented Dec 9, 2018

ifdef's in line 33 of lib/libcurl.rc and src/curl.rc are wrong

This part is missing from the commit message. Otherwise, this PR looks good to me.

@bagder

This comment has been minimized.

Copy link
Member Author

commented Dec 9, 2018

This part is missing

Right, thanks. I used #ifdef as the first word of the following line which wasn't very clever =) I'll sort that out when I merge.

@bagder

This comment has been minimized.

Copy link
Member Author

commented Dec 9, 2018

Thank you!

@bagder bagder closed this in e1360a1 Dec 9, 2018

@bagder bagder deleted the bagder/curl-rc-files branch Dec 9, 2018

@lock lock bot locked as resolved and limited conversation to collaborators Mar 9, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can’t perform that action at this time.