Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http: don't set CURLINFO_CONDITION_UNMET for http status code 204 #3359

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
2 participants
@mkauf
Copy link
Contributor

commented Dec 10, 2018

The http status code 204 (No Content) should not change the "condition unmet"
flag. Only the http status code 304 (Not Modified) should do this.

http: don't set CURLINFO_CONDITION_UNMET for http status code 204
The http status code 204 (No Content) should not change the "condition unmet"
flag. Only the http status code 304 (Not Modified) should do this.
@bagder

bagder approved these changes Dec 11, 2018

@bagder

This comment has been minimized.

Copy link
Member

commented Dec 11, 2018

thanks @mkauf, I went ahead and merged it now just because we're closing in to release and I want this in...

@bagder

This comment has been minimized.

Copy link
Member

commented Dec 11, 2018

(but typo'ed the issue number in the c8bf8cc commit message ... )

@bagder bagder closed this Dec 11, 2018

@mkauf mkauf deleted the mkauf:condition_unmet_204 branch Dec 14, 2018

mkauf referenced this pull request Dec 14, 2018

http: don't set CURLINFO_CONDITION_UNMET for http status code 204
The http status code 204 (No Content) should not change the "condition
unmet" flag. Only the http status code 304 (Not Modified) should do
this.

Closes #359

@lock lock bot locked as resolved and limited conversation to collaborators Mar 14, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.