Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ldap: Fixed multiple regressions #3362

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
2 participants
@samsinsane
Copy link
Contributor

commented Dec 11, 2018

  • Match URL scheme with LDAP and LDAPS
  • Retrieve attributes, scope and filter from URL query instead

These regressions were introduced in #3017

ldap: Fixed multiple regressions
- Match URL scheme with LDAP and LDAPS
- Retrieve attributes, scope and filter from URL query instead
@bagder

bagder approved these changes Dec 11, 2018

@bagder bagder added the LDAP label Dec 11, 2018

@bagder

This comment has been minimized.

Copy link
Member

commented Dec 11, 2018

./ldap.c:864:5: warning: if with space (SPACEBEFOREPAREN)
   if (!query) {
     ^
@bagder

This comment has been minimized.

Copy link
Member

commented Dec 11, 2018

As we're a bit tight on time to release, I'll amend this myself before merge.

@bagder

This comment has been minimized.

Copy link
Member

commented Dec 11, 2018

Thanks!

@bagder bagder closed this in 1b443a7 Dec 11, 2018

@samsinsane samsinsane deleted the Euclideon:ldapFixes branch Dec 11, 2018

@samsinsane

This comment has been minimized.

Copy link
Contributor Author

commented Dec 11, 2018

Sorry about that, thanks for fixing it up and merging!

@lock lock bot locked as resolved and limited conversation to collaborators Mar 11, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.