Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ldap: Fixed multiple regressions #3362

Closed
wants to merge 1 commit into from
Closed

ldap: Fixed multiple regressions #3362

wants to merge 1 commit into from

Conversation

samsinsane
Copy link
Contributor

@samsinsane samsinsane commented Dec 11, 2018 •
edited

  • Match URL scheme with LDAP and LDAPS
  • Retrieve attributes, scope and filter from URL query instead

These regressions were introduced in #3017

@samsinsane
ldap: Fixed multiple regressions
55be1fd 
- Match URL scheme with LDAP and LDAPS
- Retrieve attributes, scope and filter from URL query instead
bagder
bagder approved these changes Dec 11, 2018
View changes
@bagder bagder added the LDAP label Dec 11, 2018
@bagder
Copy link
Member

@bagder bagder commented Dec 11, 2018 

./ldap.c:864:5: warning: if with space (SPACEBEFOREPAREN)
   if (!query) {
     ^

@bagder
Copy link
Member

@bagder bagder commented Dec 11, 2018

As we're a bit tight on time to release, I'll amend this myself before merge.

@bagder
Copy link
Member

@bagder bagder commented Dec 11, 2018

Thanks!

@samsinsane samsinsane deleted the ldapFixes branch Dec 11, 2018
@samsinsane
Copy link
Contributor Author

@samsinsane samsinsane commented Dec 11, 2018

Sorry about that, thanks for fixing it up and merging!

@lock lock bot locked as resolved and limited conversation to collaborators Mar 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bagder bagder

Assignees
No one assigned
Labels
LDAP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@samsinsane @bagder