-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
connect: Add TCP Fast Open support for Windows #3378
Conversation
This is the former PR #3327, saved by Johannes Schindelin, rebased, squashed and pushed again. Requires Windows 10 ver 1607 or newer
Thanks for the tumbs up. If you're also 👍 for actually merging this, I'm all ears. I personally cannot tell how the logic around the presence and use of this function is or should be! |
@@ -609,6 +609,12 @@ Vista | |||
# endif | |||
#endif | |||
|
|||
/* Define if you have the ConnectEx WinSock 2 extension */ | |||
/* This requires a build target of WinXP or newer */ | |||
#if defined(_WIN32_WINNT) && (_WIN32_WINNT >= 0x0501) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need this here at all if it's overridden in curl_setup.h anyway?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The curl_setup.h logic doesn't define HAVE_CONNECTEX
though so if we would remove this section the other one would need polish.
It is definitely not ready for merging in my mind. I mentioned in the original PR how I think the runtime check should work: simply by verifying that the |
I slapped the "needs update" label on this to mark that its not ready. I personally am not the right person to drive through the changed mentioned above so I'll leave this open for a while to see if someone else wants to take it through to the goal or if it doesn't happen in another several weeks I'll probably close and add a mention in the TODO. |
This is the former PR #3327, saved by Johannes Schindelin (@dscho), rebased, squashed
and pushed again.
Requires Windows 10 ver 1607 or newer