Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added cleanup for cyassl #3395

Closed
wants to merge 2 commits into from

Conversation

@dgarske
Copy link
Contributor

commented Dec 19, 2018

Resolves possible memory leak when using ECC fixed point cache.
Fixes #3387

@danielgustafsson
Copy link
Member

left a comment

This looks fine to me.

@@ -794,6 +794,12 @@ static int Curl_cyassl_init(void)
}


void Curl_cyassl_cleanup(void)

This comment has been minimized.

Copy link
@danielgustafsson

danielgustafsson Dec 19, 2018

Member

I assume checksrc will complain loudly here, should be this I believe:

void
Curl_cyassl_cleanup(void)
{
  CyaSSL_Cleanup();
}
@bagder
bagder approved these changes Dec 19, 2018
Copy link
Member

left a comment

Lovely!

@danielgustafsson danielgustafsson self-assigned this Dec 19, 2018

@lock lock bot locked as resolved and limited conversation to collaborators Mar 20, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can’t perform that action at this time.