Skip to content

Added cleanup for cyassl#3395

Closed
dgarske wants to merge 2 commits intocurl:masterfrom
dgarske:cyassl_cleanup
Closed

Added cleanup for cyassl#3395
dgarske wants to merge 2 commits intocurl:masterfrom
dgarske:cyassl_cleanup

Conversation

@dgarske
Copy link
Copy Markdown
Contributor

@dgarske dgarske commented Dec 19, 2018

Resolves possible memory leak when using ECC fixed point cache.
Fixes #3387

Copy link
Copy Markdown
Member

@danielgustafsson danielgustafsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me.

Comment thread lib/vtls/cyassl.c Outdated
}


void Curl_cyassl_cleanup(void)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume checksrc will complain loudly here, should be this I believe:

void
Curl_cyassl_cleanup(void)
{
  CyaSSL_Cleanup();
}

Copy link
Copy Markdown
Member

@bagder bagder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely!

@danielgustafsson danielgustafsson self-assigned this Dec 19, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Mar 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Memory leak in wolfssl in threaded function

3 participants