New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disconnect: separate connections and easy handles better #3400

Merged
merged 3 commits into from Dec 22, 2018

Conversation

Projects
None yet
1 participant
@bagder
Copy link
Member

bagder commented Dec 20, 2018

Do not assume/store assocation between a given easy handle and the
connection if it can be avoided.

Long-term, the 'conn->data' pointer should probably be removed as it is a
little too error-prone. Still used very widely though.

Reported-by: masbug on github
Fixes #3391

@bagder

This comment has been minimized.

Copy link
Member Author

bagder commented Dec 21, 2018

Parts of the libssh fix is now in #3403 since it shouldn't be related to this work!

@bagder

This comment has been minimized.

Copy link
Member Author

bagder commented Dec 21, 2018

#3403 really needs to land first, then this third commit can be cleaned up and then I can continue on this PR.

bagder added some commits Dec 20, 2018

disconnect: separate connections and easy handles better
Do not assume/store assocation between a given easy handle and the
connection if it can be avoided.

Long-term, the 'conn->data' pointer should probably be removed as it is a
little too error-prone. Still used very widely though.

Reported-by: masbug on github
Fixes #3391
Closes #3400

@bagder bagder force-pushed the bagder/connection-easy-detach branch from 6265d2a to c98ee5f Dec 22, 2018

@bagder bagder merged commit c98ee5f into master Dec 22, 2018

17 of 19 checks passed

continuous-integration/appveyor/branch Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
LGTM analysis: C/C++ No alert changes
Details
LGTM analysis: Python No code changes detected
Details
buildbot/curl-unthreaded-solaris10-i386 Build done.
Details
buildbot/curl-unthreaded-solaris10-sparc Build done.
Details
buildbot/curl_winssl_cross_x64 Build done.
Details
buildbot/curl_winssl_cross_x64_dbg Build done.
Details
buildbot/curl_winssl_cross_x86 Build done.
Details
buildbot/curl_winssl_cross_x86_dbg Build done.
Details
buildbot/curl_winssl_msys2_mingw32 Build done.
Details
buildbot/curl_winssl_msys2_mingw32_dbg Build done.
Details
buildbot/curl_winssl_msys2_mingw32_stc Build done.
Details
buildbot/curl_winssl_msys2_mingw64 Build done.
Details
buildbot/curl_winssl_msys2_mingw64_dbg Build done.
Details
buildbot/curl_winssl_msys2_mingw64_stc Build done.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.06%) to 75.009%
Details

@bagder bagder deleted the bagder/connection-easy-detach branch Dec 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment