urlapi: fix parsing ipv6 with zone index #3411
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous fix for parsing IPv6 URLs with a zone index was a paddle short for URLs without an explicit port. Fix for this case and add a unit test case. This bug was highlighted by issue curl#3408, and while it's not the full fix for the problem there it is an isolated bug that should be fixed.
bagder
approved these changes
Dec 30, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous fix for parsing IPv6 URLs with a zone index was a paddle short for URLs without an explicit port. Fix for this case and add a unit test case.
This bug was highlighted by issue #3408, and while it's not the full fix for the problem there it is an isolated bug that should be fixed.