Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schannel: fix compiler warning #3435

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
2 participants
@MarcelRaad
Copy link
Member

commented Jan 3, 2019

When building with Unicode on MSVC, the compiler warns about freeing a
pointer to const in Curl_unicodefree. Fix this by declaring it as
non-const and casting the argument to Curl_convert_UTF8_to_tchar to
non-const too, like we do in all other places.

schannel: fix compiler warning
When building with Unicode on MSVC, the compiler warns about freeing a
pointer to const in Curl_unicodefree. Fix this by declaring it as
non-const and casting the argument to Curl_convert_UTF8_to_tchar to
non-const too, like we do in all other places.
@bagder

bagder approved these changes Jan 4, 2019

Copy link
Member

left a comment

Looks fine, apart from the missing updated copyright year range that travis found! =)

@MarcelRaad

This comment has been minimized.

Copy link
Member Author

commented Jan 6, 2019

Thanks! I still have to get used to that.

@MarcelRaad MarcelRaad closed this in e939afe Jan 6, 2019

@MarcelRaad MarcelRaad deleted the MarcelRaad:schannel_compiler_warning branch Jan 6, 2019

@lock lock bot locked as resolved and limited conversation to collaborators Apr 6, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.