Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: added checks for variadic macros #3459

Merged
merged 1 commit into from Jan 11, 2019

Conversation

@snikulov
Copy link
Member

commented Jan 11, 2019

Added checks for HAVE_VARIADIC_MACROS_C99 and HAVE_VARIADIC_MACROS_GCC to match autoconfig behavior (Ref: acinclude.m4).

Fixes #3142, #3452

@bagder
bagder approved these changes Jan 11, 2019
@MarcelRaad
Copy link
Member

left a comment

Great! Thanks!

@snikulov

This comment has been minimized.

Copy link
Member Author

commented Jan 11, 2019

@bagder can I merge? Looks like baseline for this fix also failed on AppVeyor

@bagder

This comment has been minimized.

Copy link
Member

commented Jan 11, 2019

Go ahead, that failure looked like another false positive and I restarted it now in case you'd rather wait and see.

@snikulov snikulov merged commit 52e27fe into curl:master Jan 11, 2019

14 of 15 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
LGTM analysis: C/C++ No alert changes
Details
LGTM analysis: Python No code changes detected
Details
buildbot/curl_winssl_cross_x64 Build done.
Details
buildbot/curl_winssl_cross_x64_dbg Build done.
Details
buildbot/curl_winssl_cross_x86 Build done.
Details
buildbot/curl_winssl_cross_x86_dbg Build done.
Details
buildbot/curl_winssl_msys2_mingw32 Build done.
Details
buildbot/curl_winssl_msys2_mingw32_dbg Build done.
Details
buildbot/curl_winssl_msys2_mingw32_stc Build done.
Details
buildbot/curl_winssl_msys2_mingw64 Build done.
Details
buildbot/curl_winssl_msys2_mingw64_dbg Build done.
Details
buildbot/curl_winssl_msys2_mingw64_stc Build done.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.06%) to 74.827%
Details

@snikulov snikulov deleted the snikulov:cmake_have_variadic_macro_checks branch Jan 14, 2019

@lock lock bot locked as resolved and limited conversation to collaborators Apr 14, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can’t perform that action at this time.