Skip to content

cmake: added checks for variadic macros#3459

Merged
snikulov merged 1 commit intocurl:masterfrom
snikulov:cmake_have_variadic_macro_checks
Jan 11, 2019
Merged

cmake: added checks for variadic macros#3459
snikulov merged 1 commit intocurl:masterfrom
snikulov:cmake_have_variadic_macro_checks

Conversation

@snikulov
Copy link
Contributor

Added checks for HAVE_VARIADIC_MACROS_C99 and HAVE_VARIADIC_MACROS_GCC to match autoconfig behavior (Ref: acinclude.m4).

Fixes #3142, #3452

Copy link
Member

@MarcelRaad MarcelRaad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks!

@snikulov
Copy link
Contributor Author

@bagder can I merge? Looks like baseline for this fix also failed on AppVeyor

@bagder
Copy link
Member

bagder commented Jan 11, 2019

Go ahead, that failure looked like another false positive and I restarted it now in case you'd rather wait and see.

@snikulov snikulov merged commit 52e27fe into curl:master Jan 11, 2019
@snikulov snikulov deleted the cmake_have_variadic_macro_checks branch January 14, 2019 07:05
@lock lock bot locked as resolved and limited conversation to collaborators Apr 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Development

Successfully merging this pull request may close these issues.

3 participants