New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure: fix recv/send/select detection on Android #3484

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@hhb
Copy link
Contributor

hhb commented Jan 18, 2019

This reverts commit 58845f2.

The overloadable attribute was removed starting NDK17. Actually they only exist in two NDK versions (15 and 16). With overloadable, the first condition tried will succeed. Results in wrong detection result.

configure: fix recv/send/select detection on Android
This reverts commit d4f2520.

The overloadable attribute is removed again starting from NDK17. Actually they only exist in two NDK versions (15 and 16). With overloadable, the first condition tried will succeed. Results in wrong detection result.

@bagder bagder added the build label Jan 18, 2019

@jay

This comment has been minimized.

Copy link
Member

jay commented Jan 18, 2019

just to be clear this is a partial revert correct? we're still fine for 15 and 16?

@hhb

This comment has been minimized.

Copy link
Contributor Author

hhb commented Jan 19, 2019

just to be clear this is a partial revert correct? we're still fine for 15 and 16?

No. configure will fail on NDK 15 and 16. The latest NDK now is r19. I think people who actively upgrade curl should also upgrade ndk...

Also when overloadable was added to fix build on ndk 15, it actually broke on all NDKs before 15 :).

If it is still important to support ndk 15, one alternative is to include android/ndk_version.h and check. But this header was introduced in ndk 16, so we have to detect it first.

@bagder

This comment has been minimized.

Copy link
Member

bagder commented Jan 19, 2019

If someone really want to add support for the now old NDKs using that approach, I think we can expect those users to bring a fix/#ifdef setup to make those work. I agree with @hhb that the latest few versions are more important to support in curl code.

@bagder

This comment has been minimized.

Copy link
Member

bagder commented Jan 19, 2019

Thanks!

@bagder bagder closed this in 21c3794 Jan 19, 2019

@hhb hhb deleted the hhb:patch-2 branch Jan 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment