Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
configure: fix recv/send/select detection on Android #3484
This reverts commit d4f2520. The overloadable attribute is removed again starting from NDK17. Actually they only exist in two NDK versions (15 and 16). With overloadable, the first condition tried will succeed. Results in wrong detection result.
No. configure will fail on NDK 15 and 16. The latest NDK now is r19. I think people who actively upgrade curl should also upgrade ndk...
Also when overloadable was added to fix build on ndk 15, it actually broke on all NDKs before 15 :).
If it is still important to support ndk 15, one alternative is to include android/ndk_version.h and check. But this header was introduced in ndk 16, so we have to detect it first.