configure: fix recv/send/select detection on Android#3484
configure: fix recv/send/select detection on Android#3484hhb wants to merge 1 commit intocurl:masterfrom hhb:patch-2
Conversation
This reverts commit d4f2520. The overloadable attribute is removed again starting from NDK17. Actually they only exist in two NDK versions (15 and 16). With overloadable, the first condition tried will succeed. Results in wrong detection result.
|
just to be clear this is a partial revert correct? we're still fine for 15 and 16? |
No. configure will fail on NDK 15 and 16. The latest NDK now is r19. I think people who actively upgrade curl should also upgrade ndk... Also when overloadable was added to fix build on ndk 15, it actually broke on all NDKs before 15 :). If it is still important to support ndk 15, one alternative is to include android/ndk_version.h and check. But this header was introduced in ndk 16, so we have to detect it first. |
|
If someone really want to add support for the now old NDKs using that approach, I think we can expect those users to bring a fix/#ifdef setup to make those work. I agree with @hhb that the latest few versions are more important to support in curl code. |
|
Thanks! |
3 participants
This reverts commit 58845f2.
The overloadable attribute was removed starting NDK17. Actually they only exist in two NDK versions (15 and 16). With overloadable, the first condition tried will succeed. Results in wrong detection result.