Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sigpipe: if MBEDTLS is used, force curl to ignore sigpipe. #3502

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
2 participants
@JeremieRapin
Copy link

commented Jan 28, 2019

mbedtls doesn't have a sigpipe management.
If a write/read occurs when the remote closes the socket, the signal is raised and kills the application.
Use the curl mecanisms fix this behavior.

Signed-off-by: Jeremie Rapin j.rapin@overkiz.com

Jeremie Rapin
sigpipe: if MBEDTLS is used, force curl to ignore sigpipe.
mbedtls doesn't have a sigpipe management.
If a write/read occurs when the remote closes the socket, the signal is raised and kills the application.
Use the curl mecanisms fix this behavior.

Signed-off-by: Jeremie Rapin <j.rapin@overkiz.com>
@bagder

bagder approved these changes Jan 28, 2019

Copy link
Member

left a comment

Thanks! Assuming this is true, the fix looks fine. I tried to find some docs about this regarding mbedTLS but failed so I will just trust you that this is the case.

@JeremieRapin

This comment has been minimized.

Copy link
Author

commented Jan 28, 2019

If it can help you, a sigpipe management appears in object net_sockets.
This piece of code is defined by:

provides an example integration of the Mbed TLS library into a BSD sockets implementation. The module is intended to be an example of how Mbed TLS can be integrated into a networking stack, as well as to be Mbed TLS's network integration for its supported platforms.

@bagder

This comment has been minimized.

Copy link
Member

commented Jan 28, 2019

Thanks!

@bagder bagder closed this in a9d9a3a Jan 28, 2019

@lock lock bot locked as resolved and limited conversation to collaborators Apr 28, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.