sigpipe: if MBEDTLS is used, force curl to ignore sigpipe.#3502
Closed
JeremieRapin wants to merge 1 commit intocurl:masterfrom
Closed
sigpipe: if MBEDTLS is used, force curl to ignore sigpipe.#3502JeremieRapin wants to merge 1 commit intocurl:masterfrom
JeremieRapin wants to merge 1 commit intocurl:masterfrom
Conversation
mbedtls doesn't have a sigpipe management. If a write/read occurs when the remote closes the socket, the signal is raised and kills the application. Use the curl mecanisms fix this behavior. Signed-off-by: Jeremie Rapin <j.rapin@overkiz.com>
bagder
approved these changes
Jan 28, 2019
Member
bagder
left a comment
bagder
left a comment
There was a problem hiding this comment.
Thanks! Assuming this is true, the fix looks fine. I tried to find some docs about this regarding mbedTLS but failed so I will just trust you that this is the case.
Author
|
If it can help you, a sigpipe management appears in object net_sockets.
|
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mbedtls doesn't have a sigpipe management.
If a write/read occurs when the remote closes the socket, the signal is raised and kills the application.
Use the curl mecanisms fix this behavior.
Signed-off-by: Jeremie Rapin j.rapin@overkiz.com