New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schannel: stop calling it "winssl" #3504

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@bagder
Copy link
Member

bagder commented Jan 29, 2019

Stick to "Schannel" everywhere. The configure option --with-winssl is
kept to allow existing builds to work but a new --enable-schannel is
added as an alias.

@bagder bagder added the SSL/TLS label Jan 29, 2019

Show resolved Hide resolved configure.ac
schannel: stop calling it "winssl"
Stick to "Schannel" everywhere. The configure option --with-winssl is
kept to allow existing builds to work but --with-schannel is added as an
alias.

@bagder bagder force-pushed the bagder/Schannel-winssl branch from 5204ba9 to 48f8b7d Jan 29, 2019

@danielgustafsson

This comment has been minimized.

Copy link
Member

danielgustafsson commented Jan 29, 2019

@bagder

This comment has been minimized.

Copy link
Member Author

bagder commented Jan 29, 2019

should we do the same for Apple Secure Transport and move away from darwinssl?

I think so, yes. I think we're the odd ones here using these names and I think users and people in general will understand our terms better if we use the more appropriate and established names.

Darwinssl is slightly more engraved in curl though.

CURLSSLBACKEND_DARWINSSL is exposed in the API so we can just rename that, but we can add an alias. It is also the name used for the backend internally so when setting CURL_SSL_BACKEND that's the name to use. Possibly something else.

@danielgustafsson

This comment has been minimized.

Copy link
Member

danielgustafsson commented Jan 29, 2019

@nickzman

This comment has been minimized.

Copy link
Collaborator

nickzman commented Jan 30, 2019

I, too, would like to call it Secure Transport. The reason why it was called "DarwinSSL" is because Yang thought "Secure Transport" was too generic a name, but that's what Apple calls it, and no one else uses that name. At the time, I just went with the flow.

@bagder bagder closed this in 180501c Feb 1, 2019

@bagder bagder deleted the bagder/Schannel-winssl branch Feb 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment