Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stderr comparison to the test suite. #3536

Closed
wants to merge 1 commit into from

Conversation

@gevaerts
Copy link
Contributor

commented Feb 8, 2019

The code is more or less copied from the stdout comparison code, maybe
some better reuse is possible.

@gevaerts gevaerts force-pushed the gevaerts:stderr-tests branch from a0e8d93 to c84ceb4 Feb 8, 2019

@bagder

This comment has been minimized.

Copy link
Member

commented Feb 8, 2019

It looks like test 506 was wrongly written as if <stderr> already existed, so now it fails due to the mismatch!

@gevaerts

This comment has been minimized.

Copy link
Contributor Author

commented Feb 8, 2019

Oh, indeed. I didn't test with various dns backends so I didn't spot that one! I'll have a proper look.

@gevaerts gevaerts force-pushed the gevaerts:stderr-tests branch from c84ceb4 to 403b383 Feb 8, 2019

Add stderr comparison to the test suite.
The code is more or less copied from the stdout comparison code, maybe
some better reuse is possible.

test 1457 is adjusted to make the output actually match (by using --silent)
test 506 used <stderr> without actually needing it, so that <stderr> block is removed

@gevaerts gevaerts force-pushed the gevaerts:stderr-tests branch from 403b383 to 4cb00c0 Feb 11, 2019

@bagder
bagder approved these changes Feb 11, 2019
@bagder

This comment has been minimized.

Copy link
Member

commented Feb 11, 2019

Thanks!

@bagder bagder closed this in 35a8fd2 Feb 11, 2019

@gevaerts gevaerts deleted the gevaerts:stderr-tests branch Feb 12, 2019

@lock lock bot locked as resolved and limited conversation to collaborators May 13, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants
You can’t perform that action at this time.