Add stderr comparison to the test suite. #3536
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gevaerts
force-pushed
the
stderr-tests
branch
from
a0e8d93
to
c84ceb4
Compare
|
It looks like test 506 was wrongly written as if |
|
Oh, indeed. I didn't test with various dns backends so I didn't spot that one! I'll have a proper look. |
gevaerts
force-pushed
the
stderr-tests
branch
from
c84ceb4
to
403b383
Compare
The code is more or less copied from the stdout comparison code, maybe some better reuse is possible. test 1457 is adjusted to make the output actually match (by using --silent) test 506 used <stderr> without actually needing it, so that <stderr> block is removed
gevaerts
force-pushed
the
stderr-tests
branch
from
403b383
to
4cb00c0
Compare
bagder
approved these changes
Feb 11, 2019
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
The code is more or less copied from the stdout comparison code, maybe
some better reuse is possible.