Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd stderr comparison to the test suite. #3536
Closed
Conversation
This comment has been minimized.
This comment has been minimized.
|
It looks like test 506 was wrongly written as if |
This comment has been minimized.
This comment has been minimized.
|
Oh, indeed. I didn't test with various dns backends so I didn't spot that one! I'll have a proper look. |
The code is more or less copied from the stdout comparison code, maybe some better reuse is possible. test 1457 is adjusted to make the output actually match (by using --silent) test 506 used <stderr> without actually needing it, so that <stderr> block is removed
This comment has been minimized.
This comment has been minimized.
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
gevaerts commentedFeb 8, 2019
The code is more or less copied from the stdout comparison code, maybe
some better reuse is possible.