Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd stderr comparison to the test suite. #3536
Conversation
gevaerts
force-pushed the
gevaerts:stderr-tests
branch
from
a0e8d93
to
c84ceb4
Feb 8, 2019
This comment has been minimized.
This comment has been minimized.
|
It looks like test 506 was wrongly written as if |
This comment has been minimized.
This comment has been minimized.
|
Oh, indeed. I didn't test with various dns backends so I didn't spot that one! I'll have a proper look. |
gevaerts
force-pushed the
gevaerts:stderr-tests
branch
from
c84ceb4
to
403b383
Feb 8, 2019
gevaerts
force-pushed the
gevaerts:stderr-tests
branch
from
403b383
to
4cb00c0
Feb 11, 2019
bagder
approved these changes
Feb 11, 2019
This comment has been minimized.
This comment has been minimized.
|
Thanks! |
bagder
closed this
in
35a8fd2
Feb 11, 2019
gevaerts
deleted the
gevaerts:stderr-tests
branch
Feb 12, 2019
lock
bot
locked as resolved and limited conversation to collaborators
May 13, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
gevaerts commentedFeb 8, 2019
The code is more or less copied from the stdout comparison code, maybe
some better reuse is possible.